lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SUNRPC: Clean up one_sock_name()

Browse Source 
Clean up svc_one_sock_name() by setting up automatic variables for
frequently used expressions.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
Chuck Lever
2009-04-23 19:33:03 -04:00
committed by J. Bruce Fields
parent 58de2f8658
commit 017cb47f46
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
net/sunrpc/svcsock.c
View File

@@ -242,26 +242,27 @@ out:
*/ */
static int svc_one_sock_name(struct svc_sock *svsk, char *buf, int remaining) static int svc_one_sock_name(struct svc_sock *svsk, char *buf, int remaining)
{ {
const struct sock *sk = svsk->sk_sk;
const char *proto_name = sk->sk_protocol == IPPROTO_UDP ?
"udp" : "tcp";
int len; int len;
switch(svsk->sk_sk->sk_family) { switch (sk->sk_family) {
case PF_INET: case PF_INET:
len = snprintf(buf, remaining, "ipv4 %s %pI4 %d\n", len = snprintf(buf, remaining, "ipv4 %s %pI4 %d\n",
svsk->sk_sk->sk_protocol == IPPROTO_UDP ? proto_name,
"udp" : "tcp", &inet_sk(sk)->rcv_saddr,
&inet_sk(svsk->sk_sk)->rcv_saddr, inet_sk(sk)->num);
inet_sk(svsk->sk_sk)->num);
break; break;
case PF_INET6: case PF_INET6:
len = snprintf(buf, remaining, "ipv6 %s %pI6 %d\n", len = snprintf(buf, remaining, "ipv6 %s %pI6 %d\n",
svsk->sk_sk->sk_protocol == IPPROTO_UDP ? proto_name,
"udp" : "tcp", &inet6_sk(sk)->rcv_saddr,
&inet6_sk(svsk->sk_sk)->rcv_saddr, inet_sk(sk)->num);
inet_sk(svsk->sk_sk)->num);
break; break;
default: default:
len = snprintf(buf, remaining, "*unknown-%d*\n", len = snprintf(buf, remaining, "*unknown-%d*\n",
svsk->sk_sk->sk_family); sk->sk_family);
} }
if (len >= remaining) { if (len >= remaining) {