lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hamradio: Remove unneeded and deprecated cli()/sti() calls in dmascc.c

Browse Source 
These cli()/sti() calls are made in start_timer() and are therefor
redundant since the register_lock is now used to protect register
io from within scc_isr() and write_scc() (where all calls to
start_timer() originate).

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Mark Asselstine
2008-04-21 14:44:16 -07:00
committed by David S. Miller
parent 92998dd495
commit 02651d20a3
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/hamradio/dmascc.c
View File

@@ -1083,15 +1083,12 @@ static void start_timer(struct scc_priv *priv, int t, int r15)
if (t == 0) { if (t == 0) {
tm_isr(priv); tm_isr(priv);
} else if (t > 0) { } else if (t > 0) {
save_flags(flags);
cli();
outb(t & 0xFF, priv->tmr_cnt); outb(t & 0xFF, priv->tmr_cnt);
outb((t >> 8) & 0xFF, priv->tmr_cnt); outb((t >> 8) & 0xFF, priv->tmr_cnt);
if (priv->type != TYPE_TWIN) { if (priv->type != TYPE_TWIN) {
write_scc(priv, R15, r15 | CTSIE); write_scc(priv, R15, r15 | CTSIE);
priv->rr0 |= CTS; priv->rr0 |= CTS;
} }
restore_flags(flags);
} }
} }