lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[libata] pata_rb532_cf: fix signature of the xfer function

Browse Source 
Per definition, this function should return the number of bytes
consumed. As the original parameter "buflen" is being decremented inside
the read/write loop, save it in "retlen" at the beginning.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Acked-by: Sergei Shtyltov <sshtylyov@ru.mvista.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Phil Sutter
2008-11-28 20:48:35 +01:00
committed by Jeff Garzik
parent 9f14786e27
commit 03f60840fa
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/pata_rb532_cf.c
View File

@@ -74,11 +74,12 @@ static void rb532_pata_exec_command(struct ata_port *ap,
rb532_pata_finish_io(ap); rb532_pata_finish_io(ap);
} }
static void rb532_pata_data_xfer(struct ata_device *adev, unsigned char *buf, static unsigned int rb532_pata_data_xfer(struct ata_device *adev, unsigned char *buf,
unsigned int buflen, int write_data) unsigned int buflen, int write_data)
{ {
struct ata_port *ap = adev->link->ap; struct ata_port *ap = adev->link->ap;
void __iomem *ioaddr = ap->ioaddr.data_addr; void __iomem *ioaddr = ap->ioaddr.data_addr;
int retlen = buflen;
if (write_data) { if (write_data) {
for (; buflen > 0; buflen--, buf++) for (; buflen > 0; buflen--, buf++)
@@ -89,6 +90,7 @@ static void rb532_pata_data_xfer(struct ata_device *adev, unsigned char *buf,
} }
rb532_pata_finish_io(adev->link->ap); rb532_pata_finish_io(adev->link->ap);
return retlen;
} }
static void rb532_pata_freeze(struct ata_port *ap) static void rb532_pata_freeze(struct ata_port *ap)