lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (10171): Use usb_set_intfdata

Browse Source 
This code had calls to both usb_set_intfdata and dev_set_drvdata, doing the
same thing.

The semantic patch that lead to finding this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@header@
@@

@same depends on header@
position p;
@@

usb_set_intfdata@p(...) { ... }

@depends on header@
position _p!=same.p;
identifier _f;
struct usb_interface *intf;
expression data;
@@

_f@_p(...) { <+...
- dev_set_drvdata(&intf->dev, data);
+ usb_set_intfdata(intf, data);
...+> }

// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall
2009-01-01 17:14:58 -03:00
committed by Mauro Carvalho Chehab
parent 6b55009e1d
commit 03fb02c604
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/media/video/zr364xx.c
View File

@@ -893,7 +893,6 @@ static void zr364xx_disconnect(struct usb_interface *intf)
{ {
struct zr364xx_camera *cam = usb_get_intfdata(intf); struct zr364xx_camera *cam = usb_get_intfdata(intf);
usb_set_intfdata(intf, NULL); usb_set_intfdata(intf, NULL);
dev_set_drvdata(&intf->dev, NULL);
dev_info(&intf->dev, DRIVER_DESC " webcam unplugged\n"); dev_info(&intf->dev, DRIVER_DESC " webcam unplugged\n");
if (cam->vdev) if (cam->vdev)
video_unregister_device(cam->vdev); video_unregister_device(cam->vdev);