lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

NFSv4.1: integer overflow in decode_cb_sequence_args()

Browse Source 
This seems like it could overflow on 32 bits.  Use kmalloc_array() which
has overflow protection built in.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Dan Carpenter
2012-06-12 10:37:08 +03:00
committed by Trond Myklebust
parent 92123e068e
commit 0439f31c35
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/nfs/callback_xdr.c
View File

@@ -455,9 +455,9 @@ static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp,
args->csa_nrclists = ntohl(*p++); args->csa_nrclists = ntohl(*p++);
args->csa_rclists = NULL; args->csa_rclists = NULL;
if (args->csa_nrclists) { if (args->csa_nrclists) {
args->csa_rclists = kmalloc(args->csa_nrclists * args->csa_rclists = kmalloc_array(args->csa_nrclists,
sizeof(*args->csa_rclists), sizeof(*args->csa_rclists),
GFP_KERNEL); GFP_KERNEL);
if (unlikely(args->csa_rclists == NULL)) if (unlikely(args->csa_rclists == NULL))
goto out; goto out;