lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tracing: x86, mmiotrace: code consistency/legibility improvement

Browse Source 
kmmio_probe being *p and kmmio_fault_page being sometimes *f and
sometimes *p is not helpful.

[ Impact: cleanup ]

Signed-off-by: Stuart Bennett <stuart@freedesktop.org>
Acked-by: Pekka Paalanen <pq@iki.fi>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <1240946271-7083-3-git-send-email-stuart@freedesktop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Stuart Bennett
2009-04-28 20:17:49 +01:00
committed by Ingo Molnar
parent 7d7d2b8031
commit 0492e1bb8f
1 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
arch/x86/mm/kmmio.c
View File

@@ -97,13 +97,13 @@ static struct kmmio_probe *get_kmmio_probe(unsigned long addr)
static struct kmmio_fault_page *get_kmmio_fault_page(unsigned long page) static struct kmmio_fault_page *get_kmmio_fault_page(unsigned long page)
{ {
struct list_head *head; struct list_head *head;
struct kmmio_fault_page *p; struct kmmio_fault_page *f;
page &= PAGE_MASK; page &= PAGE_MASK;
head = kmmio_page_list(page); head = kmmio_page_list(page);
list_for_each_entry_rcu(p, head, list) { list_for_each_entry_rcu(f, head, list) {
if (p->page == page) if (f->page == page)
return p; return f;
} }
return NULL; return NULL;
} }
@@ -439,12 +439,12 @@ static void rcu_free_kmmio_fault_pages(struct rcu_head *head)
head, head,
struct kmmio_delayed_release, struct kmmio_delayed_release,
rcu); rcu);
struct kmmio_fault_page *p = dr->release_list; struct kmmio_fault_page *f = dr->release_list;
while (p) { while (f) {
struct kmmio_fault_page *next = p->release_next; struct kmmio_fault_page *next = f->release_next;
BUG_ON(p->count); BUG_ON(f->count);
kfree(p); kfree(f);
p = next; f = next;
} }
kfree(dr); kfree(dr);
} }
@@ -453,19 +453,19 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
{ {
struct kmmio_delayed_release *dr = struct kmmio_delayed_release *dr =
container_of(head, struct kmmio_delayed_release, rcu); container_of(head, struct kmmio_delayed_release, rcu);
struct kmmio_fault_page *p = dr->release_list; struct kmmio_fault_page *f = dr->release_list;
struct kmmio_fault_page **prevp = &dr->release_list; struct kmmio_fault_page **prevp = &dr->release_list;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&kmmio_lock, flags); spin_lock_irqsave(&kmmio_lock, flags);
while (p) { while (f) {
if (!p->count) { if (!f->count) {
list_del_rcu(&p->list); list_del_rcu(&f->list);
prevp = &p->release_next; prevp = &f->release_next;
} else { } else {
*prevp = p->release_next; *prevp = f->release_next;
} }
p = p->release_next; f = f->release_next;
} }
spin_unlock_irqrestore(&kmmio_lock, flags); spin_unlock_irqrestore(&kmmio_lock, flags);