lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sparc: kernel/sbus.c: fix memory leakage

Browse Source 
The variable iommu and strbuf are not freed properly if it goes to error.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Reviewed-by: Richard Mortimer <richm@oldelvet.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Cong Ding
2013-01-17 03:28:43 +00:00
committed by David S. Miller
parent 9a9284153d
commit 04cef49e84
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
arch/sparc/kernel/sbus.c
View File

@@ -554,10 +554,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
regs = pr->phys_addr; regs = pr->phys_addr;
iommu = kzalloc(sizeof(*iommu), GFP_ATOMIC); iommu = kzalloc(sizeof(*iommu), GFP_ATOMIC);
if (!iommu)
goto fatal_memory_error;
strbuf = kzalloc(sizeof(*strbuf), GFP_ATOMIC); strbuf = kzalloc(sizeof(*strbuf), GFP_ATOMIC);
if (!strbuf) if (!iommu || !strbuf)
goto fatal_memory_error; goto fatal_memory_error;
op->dev.archdata.iommu = iommu; op->dev.archdata.iommu = iommu;
@@ -656,6 +654,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
return; return;
fatal_memory_error: fatal_memory_error:
kfree(iommu);
kfree(strbuf);
prom_printf("sbus_iommu_init: Fatal memory allocation error.\n"); prom_printf("sbus_iommu_init: Fatal memory allocation error.\n");
} }