lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ide-tape: cdev lock_kernel() pushdown

Browse Source 
->release() already has explicit lock_kernel() calls...

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Jonathan Corbet
2008-05-15 12:01:56 -06:00
parent 16750c2f32
commit 04f4ac9d1b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/ide/ide-tape.c
View File

@@ -2421,9 +2421,12 @@ static int idetape_chrdev_open(struct inode *inode, struct file *filp)
if (i >= MAX_HWIFS * MAX_DRIVES) if (i >= MAX_HWIFS * MAX_DRIVES)
return -ENXIO; return -ENXIO;
lock_kernel();
tape = ide_tape_chrdev_get(i); tape = ide_tape_chrdev_get(i);
if (!tape) if (!tape) {
unlock_kernel();
return -ENXIO; return -ENXIO;
}
debug_log(DBG_CHRDEV, "Enter %s\n", __func__); debug_log(DBG_CHRDEV, "Enter %s\n", __func__);
@@ -2482,10 +2485,12 @@ static int idetape_chrdev_open(struct inode *inode, struct file *filp)
} }
} }
} }
unlock_kernel();
return 0; return 0;
out_put_tape: out_put_tape:
ide_tape_put(tape); ide_tape_put(tape);
unlock_kernel();
return retval; return retval;
} }