lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mfd: Fix off-by-one value range checking for tps65910_i2c_write

Browse Source 
If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
This commit is contained in:
Axel Lin
2011-05-16 22:19:01 +08:00
committed by Liam Girdwood
parent 4aa922c024
commit 0514e9acd7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mfd/tps65910.c
View File

@@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
u8 msg[TPS65910_MAX_REGISTER + 1]; u8 msg[TPS65910_MAX_REGISTER + 1];
int ret; int ret;
if (bytes > (TPS65910_MAX_REGISTER + 1)) if (bytes > TPS65910_MAX_REGISTER)
return -EINVAL; return -EINVAL;
msg[0] = reg; msg[0] = reg;