lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/af_iucv: mark expected switch fall-throughs

Browse Source 
Mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

net/iucv/af_iucv.c: warning: this statement may fall
through [-Wimplicit-fallthrough=]:  => 537:3, 519:6, 2246:6, 510:6

Notice that, in this particular case, the code comment is
modified in accordance with what GCC is expecting to find.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2019-07-29 09:59:47 -05:00 committed by David S. Miller
parent e1ab2431eb
commit 05bba1edaf
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
net/iucv/af_iucv.c
View File

@ -512,7 +512,9 @@ static void iucv_sock_close(struct sock *sk)
sk->sk_state = IUCV_DISCONN; sk->sk_state = IUCV_DISCONN;
sk->sk_state_change(sk); sk->sk_state_change(sk);
} }
case IUCV_DISCONN: /* fall through */ /* fall through */
case IUCV_DISCONN:
sk->sk_state = IUCV_CLOSING; sk->sk_state = IUCV_CLOSING;
sk->sk_state_change(sk); sk->sk_state_change(sk);
@ -525,8 +527,9 @@ static void iucv_sock_close(struct sock *sk)
iucv_sock_in_state(sk, IUCV_CLOSED, 0), iucv_sock_in_state(sk, IUCV_CLOSED, 0),
timeo); timeo);
} }
/* fall through */
case IUCV_CLOSING: /* fall through */ case IUCV_CLOSING:
sk->sk_state = IUCV_CLOSED; sk->sk_state = IUCV_CLOSED;
sk->sk_state_change(sk); sk->sk_state_change(sk);
@ -535,8 +538,9 @@ static void iucv_sock_close(struct sock *sk)
skb_queue_purge(&iucv->send_skb_q); skb_queue_purge(&iucv->send_skb_q);
skb_queue_purge(&iucv->backlog_skb_q); skb_queue_purge(&iucv->backlog_skb_q);
/* fall through */
default: /* fall through */ default:
iucv_sever_path(sk, 1); iucv_sever_path(sk, 1);
} }
@ -2247,10 +2251,10 @@ static int afiucv_hs_rcv(struct sk_buff *skb, struct net_device *dev,
kfree_skb(skb); kfree_skb(skb);
break; break;
} }
/* fall through and receive non-zero length data */ /* fall through - and receive non-zero length data */
case (AF_IUCV_FLAG_SHT): case (AF_IUCV_FLAG_SHT):
/* shutdown request */ /* shutdown request */
/* fall through and receive zero length data */ /* fall through - and receive zero length data */
case 0: case 0:
/* plain data frame */ /* plain data frame */
IUCV_SKB_CB(skb)->class = trans_hdr->iucv_hdr.class; IUCV_SKB_CB(skb)->class = trans_hdr->iucv_hdr.class;