lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf tools: Check $HOME/.perfconfig ownership

Browse Source 
Just like we do already for perf.data files.

Requested-by: Ingo Molnar <mingo@elte.hu>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Christian Ohm <chr.ohm@gmx.net>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-qgokmxsmvppwpc5404qhyk7e@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2011-08-09 12:42:13 -03:00
parent 9941c96ad8
commit 069e3725dd
1 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tools/perf/util/config.c
View File

@@ -413,13 +413,32 @@ int perf_config(config_fn_t fn, void *data)
home = getenv("HOME"); home = getenv("HOME");
if (perf_config_global() && home) { if (perf_config_global() && home) {
char *user_config = strdup(mkpath("%s/.perfconfig", home)); char *user_config = strdup(mkpath("%s/.perfconfig", home));
if (!access(user_config, R_OK)) { struct stat st;
ret += perf_config_from_file(fn, user_config, data);
found += 1; if (user_config == NULL) {
} warning("Not enough memory to process %s/.perfconfig, "
free(user_config); "ignoring it.", home);
goto out;
} }
if (stat(user_config, &st) < 0)
goto out_free;
if (st.st_uid && (st.st_uid != geteuid())) {
warning("File %s not owned by current user or root, "
"ignoring it.", user_config);
goto out_free;
}
if (!st.st_size)
goto out_free;
ret += perf_config_from_file(fn, user_config, data);
found += 1;
out_free:
free(user_config);
}
out:
if (found == 0) if (found == 0)
return -1; return -1;
return ret; return ret;