lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] /proc/kallsyms reports lower-case types for some non-exported symbols

Browse Source 
This patch addresses incorrect symbol type information reported through
/proc/kallsyms.  A lowercase character should designate the symbol as local
(or non-exported).  An uppercase character should designate the symbol as
global (or external).

Without this patch, some non-exported symbols are incorrectly assigned an
upper-case designation in /proc/kallsyms.  This patch corrects this
condition by converting non-exported symbols types to lower case when
appropriate and eliminates the superfluous upcase_if_global function

Signed-off-by: Adam B. Jerome <abj@novell.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Adam B. Jerome
2006-12-06 20:35:30 -08:00
committed by Linus Torvalds
parent 960cc398a7
commit 07354a0090
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
kernel/kallsyms.c
View File

@@ -20,6 +20,7 @@
#include <linux/proc_fs.h> #include <linux/proc_fs.h>
#include <linux/sched.h> /* for cond_resched */ #include <linux/sched.h> /* for cond_resched */
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/ctype.h>
#include <asm/sections.h> #include <asm/sections.h>
@@ -301,13 +302,6 @@ struct kallsym_iter
char name[KSYM_NAME_LEN+1]; char name[KSYM_NAME_LEN+1];
}; };
/* Only label it "global" if it is exported. */
static void upcase_if_global(struct kallsym_iter *iter)
{
if (is_exported(iter->name, iter->owner))
iter->type += 'A' - 'a';
}
static int get_ksymbol_mod(struct kallsym_iter *iter) static int get_ksymbol_mod(struct kallsym_iter *iter)
{ {
iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms, iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms,
@@ -316,7 +310,10 @@ static int get_ksymbol_mod(struct kallsym_iter *iter)
if (iter->owner == NULL) if (iter->owner == NULL)
return 0; return 0;
upcase_if_global(iter); /* Label it "global" if it is exported, "local" if not exported. */
iter->type = is_exported(iter->name, iter->owner)
? toupper(iter->type) : tolower(iter->type);
return 1; return 1;
} }