lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

i2c-eg20t : Fix the issue of Combined R/W transfer mode

Browse Source 
issue-1
In case combined transfer mode fails halfway, the processing must be stopped halfway.
However currently, the processing is continued.
This patch breaks the processing.

issue-2
Currently, pch_i2c_xfer returns read/write size at that time.
However pch_i2c_xfer must return the number of messages to be read/written.
This patch modifies correctly.

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
This commit is contained in:
Tomoya MORINAGA
2011-06-23 16:17:10 +09:00
committed by Ben Dooks
parent 7a9c42ccc9
commit 07e729ce89
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/i2c/busses/i2c-eg20t.c
View File

@@ -673,7 +673,7 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap,
/* transfer not completed */ /* transfer not completed */
adap->pch_i2c_xfer_in_progress = true; adap->pch_i2c_xfer_in_progress = true;
for (i = 0; i < num; i++) { for (i = 0; i < num && ret >= 0; i++) {
pmsg = &msgs[i]; pmsg = &msgs[i];
pmsg->flags |= adap->pch_buff_mode_en; pmsg->flags |= adap->pch_buff_mode_en;
status = pmsg->flags; status = pmsg->flags;
@@ -699,7 +699,7 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap,
mutex_unlock(&pch_mutex); mutex_unlock(&pch_mutex);
return ret; return (ret < 0) ? ret : num;
} }
/** /**