lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

proc: fix sparse warnings in pagemap_read()

Browse Source 
fs/proc/task_mmu.c:696:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:696:9: warning: incorrect type in assignment (different address spaces)
fs/proc/task_mmu.c:696:9:    expected unsigned long long [noderef] [usertype] <asn:1>*out
fs/proc/task_mmu.c:696:9:    got unsigned long long [usertype] *<noident>
fs/proc/task_mmu.c:697:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:697:9: warning: incorrect type in assignment (different address spaces)
fs/proc/task_mmu.c:697:9:    expected unsigned long long [noderef] [usertype] <asn:1>*end
fs/proc/task_mmu.c:697:9:    got unsigned long long [usertype] *<noident>
fs/proc/task_mmu.c:723:12: warning: cast removes address space of expression
fs/proc/task_mmu.c:723:26: error: subtraction of different types can't work (different address spaces)
fs/proc/task_mmu.c:725:24: error: subtraction of different types can't work (different address spaces)

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
This commit is contained in:
Milind Arun Choudhary
2009-02-20 16:56:45 +03:00
committed by Alexey Dobriyan
parent 1681bc30f2
commit 09729a9919
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fs/proc/task_mmu.c
View File

@@ -693,8 +693,8 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
goto out_pages; goto out_pages;
} }
pm.out = (u64 *)buf; pm.out = (u64 __user *)buf;
pm.end = (u64 *)(buf + count); pm.end = (u64 __user *)(buf + count);
pagemap_walk.pmd_entry = pagemap_pte_range; pagemap_walk.pmd_entry = pagemap_pte_range;
pagemap_walk.pte_hole = pagemap_pte_hole; pagemap_walk.pte_hole = pagemap_pte_hole;
@@ -720,9 +720,9 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
if (ret == PM_END_OF_BUFFER) if (ret == PM_END_OF_BUFFER)
ret = 0; ret = 0;
/* don't need mmap_sem for these, but this looks cleaner */ /* don't need mmap_sem for these, but this looks cleaner */
*ppos += (char *)pm.out - buf; *ppos += (char __user *)pm.out - buf;
if (!ret) if (!ret)
ret = (char *)pm.out - buf; ret = (char __user *)pm.out - buf;
out_pages: out_pages:
for (; pagecount; pagecount--) { for (; pagecount; pagecount--) {