lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ARM] omap: usb: thou shalt not provide empty release functions

Browse Source 
... for devices.  Doing so is a bug, plain and simple, and drives
GregKH round the bend.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Russell King
2009-01-24 17:00:45 +00:00
committed by Russell King
parent b7cfc9ca6a
commit 0b23a0efec
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
arch/arm/plat-omap/usb.c
View File

@@ -431,15 +431,6 @@ bad:
/*-------------------------------------------------------------------------*/ /*-------------------------------------------------------------------------*/
#if defined(CONFIG_USB_GADGET_OMAP) || \
defined(CONFIG_USB_OHCI_HCD) || defined(CONFIG_USB_OHCI_HCD_MODULE) || \
(defined(CONFIG_USB_OTG) && defined(CONFIG_ARCH_OMAP_OTG))
static void usb_release(struct device *dev)
{
/* normally not freed */
}
#endif
#ifdef CONFIG_USB_GADGET_OMAP #ifdef CONFIG_USB_GADGET_OMAP
static struct resource udc_resources[] = { static struct resource udc_resources[] = {
@@ -466,7 +457,6 @@ static struct platform_device udc_device = {
.name = "omap_udc", .name = "omap_udc",
.id = -1, .id = -1,
.dev = { .dev = {
.release = usb_release,
.dma_mask = &udc_dmamask, .dma_mask = &udc_dmamask,
.coherent_dma_mask = 0xffffffff, .coherent_dma_mask = 0xffffffff,
}, },
@@ -497,7 +487,6 @@ static struct platform_device ohci_device = {
.name = "ohci", .name = "ohci",
.id = -1, .id = -1,
.dev = { .dev = {
.release = usb_release,
.dma_mask = &ohci_dmamask, .dma_mask = &ohci_dmamask,
.coherent_dma_mask = 0xffffffff, .coherent_dma_mask = 0xffffffff,
}, },
@@ -524,9 +513,6 @@ static struct resource otg_resources[] = {
static struct platform_device otg_device = { static struct platform_device otg_device = {
.name = "omap_otg", .name = "omap_otg",
.id = -1, .id = -1,
.dev = {
.release = usb_release,
},
.num_resources = ARRAY_SIZE(otg_resources), .num_resources = ARRAY_SIZE(otg_resources),
.resource = otg_resources, .resource = otg_resources,
}; };