lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

IB/srp: Clean up loop in srp_remove_one()

Browse Source 
Interrupts will always be enabled in srp_remove_one(), so
spin_lock_irq() can be used instead of spin_lock_irqsave().
Also, the loop takes target->scsi_host->host_lock, so target->state
can just be set to SRP_TARGET_REMOVED witout testing the old value.

Signed-off-by: Ishai Rabinovitz <ishai@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Ishai Rabinovitz
2006-06-17 20:37:31 -07:00
committed by Roland Dreier
parent 403a496fd4
commit 0c5b395239
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/infiniband/ulp/srp/ib_srp.c
View File

@ -1850,7 +1850,6 @@ static void srp_remove_one(struct ib_device *device)
struct srp_host *host, *tmp_host; struct srp_host *host, *tmp_host;
LIST_HEAD(target_list); LIST_HEAD(target_list);
struct srp_target_port *target, *tmp_target; struct srp_target_port *target, *tmp_target;
unsigned long flags;
srp_dev = ib_get_client_data(device, &srp_client); srp_dev = ib_get_client_data(device, &srp_client);
@ -1868,10 +1867,9 @@ static void srp_remove_one(struct ib_device *device)
*/ */
spin_lock(&host->target_lock); spin_lock(&host->target_lock);
list_for_each_entry(target, &host->target_list, list) { list_for_each_entry(target, &host->target_list, list) {
spin_lock_irqsave(target->scsi_host->host_lock, flags); spin_lock_irq(target->scsi_host->host_lock);
if (target->state != SRP_TARGET_REMOVED) target->state = SRP_TARGET_REMOVED;
target->state = SRP_TARGET_REMOVED; spin_unlock_irq(target->scsi_host->host_lock);
spin_unlock_irqrestore(target->scsi_host->host_lock, flags);
} }
spin_unlock(&host->target_lock); spin_unlock(&host->target_lock);