lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI: pcie port driver: remove extra printks

Browse Source 
These printks don't contain enough information to be useful.  I think it
would be more useful to have a message when a service driver binds to a
root port.  That could contain the service type, the interrupt mode and
IRQ, etc.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Bjorn Helgaas
2008-12-10 13:00:21 -07:00
committed by Jesse Barnes
parent 0663a36284
commit 0e331bf1c4
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/pcie/portdrv_core.c
View File

@@ -103,7 +103,6 @@ static int pcie_port_resume_service(struct device *dev)
*/ */
static void release_pcie_device(struct device *dev) static void release_pcie_device(struct device *dev)
{ {
dev_printk(KERN_DEBUG, dev, "free port service\n");
kfree(to_pcie_device(dev)); kfree(to_pcie_device(dev));
} }
@@ -150,7 +149,6 @@ static int assign_interrupt_mode(struct pci_dev *dev, int *vectors, int mask)
if (pos) { if (pos) {
struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES] = struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES] =
{{0, 0}, {0, 1}, {0, 2}, {0, 3}}; {{0, 0}, {0, 1}, {0, 2}, {0, 3}};
dev_info(&dev->dev, "found MSI-X capability\n");
status = pci_enable_msix(dev, msix_entries, nvec); status = pci_enable_msix(dev, msix_entries, nvec);
if (!status) { if (!status) {
int j = 0; int j = 0;
@@ -165,7 +163,6 @@ static int assign_interrupt_mode(struct pci_dev *dev, int *vectors, int mask)
if (status) { if (status) {
pos = pci_find_capability(dev, PCI_CAP_ID_MSI); pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
if (pos) { if (pos) {
dev_info(&dev->dev, "found MSI capability\n");
status = pci_enable_msi(dev); status = pci_enable_msi(dev);
if (!status) { if (!status) {
interrupt_mode = PCIE_PORT_MSI_MODE; interrupt_mode = PCIE_PORT_MSI_MODE;
@@ -239,7 +236,6 @@ static struct pcie_device* alloc_pcie_device(struct pci_dev *parent,
return NULL; return NULL;
pcie_device_init(parent, device, port_type, service_type, irq,irq_mode); pcie_device_init(parent, device, port_type, service_type, irq,irq_mode);
dev_printk(KERN_DEBUG, &device->device, "allocate port service\n");
return device; return device;
} }