lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ixgb: maybe stop tx port missed a piece

Browse Source 
back when maybe stop tx was added to the ixgb driver some mistakes
were made and the driver
a) didn't remove the tx lock, which is now un-necessary
b) didn't change the restart code to be compliant with maybe_stop

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Jesse Brandeburg
2008-07-08 15:51:07 -07:00
committed by Jeff Garzik
parent 1a342d224a
commit 0f8ecbadae
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/net/ixgb/ixgb_main.c
View File

@@ -1855,12 +1855,17 @@ ixgb_clean_tx_irq(struct ixgb_adapter *adapter)
tx_ring->next_to_clean = i; tx_ring->next_to_clean = i;
if (unlikely(netif_queue_stopped(netdev))) { if (unlikely(cleaned && netif_carrier_ok(netdev) &&
spin_lock(&adapter->tx_lock); IXGB_DESC_UNUSED(tx_ring) >= DESC_NEEDED)) {
if (netif_queue_stopped(netdev) && netif_carrier_ok(netdev) && /* Make sure that anybody stopping the queue after this
(IXGB_DESC_UNUSED(tx_ring) >= DESC_NEEDED)) * sees the new next_to_clean. */
smp_mb();
if (netif_queue_stopped(netdev) &&
!(test_bit(__IXGB_DOWN, &adapter->flags))) {
netif_wake_queue(netdev); netif_wake_queue(netdev);
spin_unlock(&adapter->tx_lock); ++adapter->restart_queue;
}
} }
if(adapter->detect_tx_hung) { if(adapter->detect_tx_hung) {