lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] hpsa: use check_signature

Browse Source 
Use check_signature to find a signature in the mmio address.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Mike Miller <mike.miller@hp.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
Akinobu Mita
2012-04-04 22:14:59 +09:00
committed by James Bottomley
parent 7155250574
commit 0fc9fd4016
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/scsi/Kconfig
View File

@@ -408,6 +408,7 @@ config BLK_DEV_3W_XXXX_RAID
config SCSI_HPSA config SCSI_HPSA
tristate "HP Smart Array SCSI driver" tristate "HP Smart Array SCSI driver"
depends on PCI && SCSI depends on PCI && SCSI
select CHECK_SIGNATURE
help help
This driver supports HP Smart Array Controllers (circa 2009). This driver supports HP Smart Array Controllers (circa 2009).
It is a SCSI alternative to the cciss driver, which is a block It is a SCSI alternative to the cciss driver, which is a block

5
drivers/scsi/hpsa.c
View File

@@ -3842,10 +3842,7 @@ static void __devinit hpsa_find_board_params(struct ctlr_info *h)
static inline bool hpsa_CISS_signature_present(struct ctlr_info *h) static inline bool hpsa_CISS_signature_present(struct ctlr_info *h)
{ {
if ((readb(&h->cfgtable->Signature[0]) != 'C') || if (!check_signature(h->cfgtable->Signature, "CISS", 4)) {
(readb(&h->cfgtable->Signature[1]) != 'I') ||
(readb(&h->cfgtable->Signature[2]) != 'S') ||
(readb(&h->cfgtable->Signature[3]) != 'S')) {
dev_warn(&h->pdev->dev, "not a valid CISS config table\n"); dev_warn(&h->pdev->dev, "not a valid CISS config table\n");
return false; return false;
} }