lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cciss: add BUILD_BUG_ON() for catching bad CommandList_struct alignment

Browse Source 
The hardware requires 64-bit alignment of commands, so add a build bug
check for that. The recent commit 8a3173de4a
didn't change the size of the command, but other additions/changes may and
thus break badly at runtime.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Jens Axboe
2009-02-27 20:14:20 +01:00
parent a7fcd37cdc
commit 10cbda97e7
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/block/cciss.c
View File

@@ -3898,6 +3898,13 @@ static struct pci_driver cciss_pci_driver = {
*/ */
static int __init cciss_init(void) static int __init cciss_init(void)
{ {
/*
* The hardware requires that commands are aligned on a 64-bit
* boundary. Given that we use pci_alloc_consistent() to allocate an
* array of them, the size must be a multiple of 8 bytes.
*/
BUILD_BUG_ON(sizeof(CommandList_struct) % 8);
printk(KERN_INFO DRIVER_NAME "\n"); printk(KERN_INFO DRIVER_NAME "\n");
/* Register for our PCI devices */ /* Register for our PCI devices */