lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

NFS: Check return value from rpc_queue_upcall()

Browse Source 
This function could fail to queue the upcall if rpc.idmapd is not running,
causing a warning message to be printed.  Instead, I want to check the
return value and revoke the key if the upcall can't be run.

Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Bryan Schumaker
2012-03-12 11:33:00 -04:00
committed by Trond Myklebust
parent 4b7c8dd205
commit 11588f493a
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fs/nfs/idmap.c
View File

@@ -656,14 +656,19 @@ static int nfs_idmap_legacy_upcall(struct key_construction *cons,
idmap->idmap_key_cons = cons; idmap->idmap_key_cons = cons;
return rpc_queue_upcall(idmap->idmap_pipe, msg); ret = rpc_queue_upcall(idmap->idmap_pipe, msg);
if (ret < 0)
goto out2;
return ret;
out2: out2:
kfree(im); kfree(im);
out1: out1:
kfree(msg); kfree(msg);
out0: out0:
complete_request_key(cons, ret); key_revoke(cons->key);
key_revoke(cons->authkey);
return ret; return ret;
} }