lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

proc: warn on non-existing proc entries

Browse Source 
* warn if creation goes on to non-existent directory
* warn if removal goes on from non-existing directory
* warn if non-existing proc entry is removed

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan
2010-03-05 13:44:00 -08:00
committed by Linus Torvalds
parent e17a5765f2
commit 12bac0d9f4
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fs/proc/generic.c
View File

@@ -312,8 +312,10 @@ static int __xlate_proc_name(const char *name, struct proc_dir_entry **ret,
if (proc_match(len, cp, de)) if (proc_match(len, cp, de))
break; break;
} }
if (!de) if (!de) {
WARN(1, "name '%s'\n", name);
return -ENOENT; return -ENOENT;
}
cp += len + 1; cp += len + 1;
} }
*residual = cp; *residual = cp;
@@ -818,8 +820,10 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent)
} }
} }
spin_unlock(&proc_subdir_lock); spin_unlock(&proc_subdir_lock);
if (!de) if (!de) {
WARN(1, "name '%s'\n", name);
return; return;
}
spin_lock(&de->pde_unload_lock); spin_lock(&de->pde_unload_lock);
/* /*