lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] ppc32: Fix string comparing in platform_notify_map

Browse Source 
Fixed odd function behavior when dev->bus_id does not contain '.' - it
compared that case 0 characters of the string and hereby reported success and
executed callback. Now bus_id's are compared correctly, extra callback
triggering eliminated.

Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Vitaly Bordug
2006-04-03 15:26:32 +04:00
committed by Paul Mackerras
parent 49c28e4e40
commit 132058f78a
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
arch/ppc/syslib/ppc_sys.c
View File

@@ -156,12 +156,13 @@ void platform_notify_map(const struct platform_notify_dev_map *map,
while (map->bus_id != NULL) { while (map->bus_id != NULL) {
idx = -1; idx = -1;
s = strrchr(dev->bus_id, '.'); s = strrchr(dev->bus_id, '.');
if (s != NULL) if (s != NULL) {
idx = (int)simple_strtol(s + 1, NULL, 10); idx = (int)simple_strtol(s + 1, NULL, 10);
else len = s - dev->bus_id;
} else {
s = dev->bus_id; s = dev->bus_id;
len = strlen(dev->bus_id);
len = s - dev->bus_id; }
if (!strncmp(dev->bus_id, map->bus_id, len)) { if (!strncmp(dev->bus_id, map->bus_id, len)) {
pdev = container_of(dev, struct platform_device, dev); pdev = container_of(dev, struct platform_device, dev);