lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI: drivers/pci/pci-sysfs.c: Add missing pci_dev_put

Browse Source 
There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.

This was fixed using the following semantic patch.

// <smpl>
@@
identifier d;
type T;
expression e;
iterator for_each_pci_dev;
@@

T *d;
...
for_each_pci_dev(d)
  {... when != pci_dev_put(d)
       when != e = d
(
   return d;
|
+  pci_dev_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall
2007-11-20 08:41:16 +01:00
committed by Greg Kroah-Hartman
parent bf164410d0
commit 151fc5dfc8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/pci-sysfs.c
View File

@@ -702,8 +702,10 @@ static int __init pci_sysfs_init(void)
sysfs_initialized = 1; sysfs_initialized = 1;
for_each_pci_dev(pdev) { for_each_pci_dev(pdev) {
retval = pci_create_sysfs_dev_files(pdev); retval = pci_create_sysfs_dev_files(pdev);
if (retval) if (retval) {
pci_dev_put(pdev);
return retval; return retval;
}
} }
return 0; return 0;