lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mtd: onenand: samsung: add missing iounmap

Browse Source 
Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
Julia Lawall
2012-01-12 10:55:05 +01:00
committed by David Woodhouse
parent 335a5f409e
commit 152b861622
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mtd/onenand/samsung.c
View File

@@ -923,7 +923,7 @@ static int s3c_onenand_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_MEM, 1); r = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (!r) { if (!r) {
dev_err(&pdev->dev, "no buffer memory resource defined\n"); dev_err(&pdev->dev, "no buffer memory resource defined\n");
return -ENOENT; err = -ENOENT;
goto ahb_resource_failed; goto ahb_resource_failed;
} }
@@ -964,7 +964,7 @@ static int s3c_onenand_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_MEM, 1); r = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (!r) { if (!r) {
dev_err(&pdev->dev, "no dma memory resource defined\n"); dev_err(&pdev->dev, "no dma memory resource defined\n");
return -ENOENT; err = -ENOENT;
goto dma_resource_failed; goto dma_resource_failed;
} }