lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Btrfs: leave critical region in btrfs_find_all_roots as soon as possible

Browse Source 
When delayed refs exist, btrfs_find_all_roots used to hold the delayed ref
mutex way longer than actually required. We ought to drop it immediately
after we're done collecting all the delayed refs.

Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
This commit is contained in:
Jan Schmidt
2012-06-22 14:01:00 +02:00
parent c3e0696523
commit 155725c9c0
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/btrfs/backref.c
View File

@@ -839,6 +839,7 @@ again:
} }
ret = __add_delayed_refs(head, delayed_ref_seq, ret = __add_delayed_refs(head, delayed_ref_seq,
&prefs_delayed); &prefs_delayed);
mutex_unlock(&head->mutex);
if (ret) { if (ret) {
spin_unlock(&delayed_refs->lock); spin_unlock(&delayed_refs->lock);
goto out; goto out;
@@ -932,8 +933,6 @@ again:
} }
out: out:
if (head)
mutex_unlock(&head->mutex);
btrfs_free_path(path); btrfs_free_path(path);
while (!list_empty(&prefs)) { while (!list_empty(&prefs)) {
ref = list_first_entry(&prefs, struct __prelim_ref, list); ref = list_first_entry(&prefs, struct __prelim_ref, list);