lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

RxRPC: Fix a potential NULL dereference

Browse Source 
Fix a potential NULL dereference bug during error handling in
rxrpc_kernel_begin_call(), whereby rxrpc_put_transport() may be handed a NULL
pointer.

This was found with a code checker (http://repo.or.cz/w/smatch.git/).

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David Howells
2009-02-06 21:50:52 -08:00
committed by David S. Miller
parent 355423d084
commit 15bde72738
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
net/rxrpc/af_rxrpc.c
View File

@@ -284,13 +284,13 @@ struct rxrpc_call *rxrpc_kernel_begin_call(struct socket *sock,
if (IS_ERR(trans)) { if (IS_ERR(trans)) {
call = ERR_CAST(trans); call = ERR_CAST(trans);
trans = NULL; trans = NULL;
goto out; goto out_notrans;
} }
} else { } else {
trans = rx->trans; trans = rx->trans;
if (!trans) { if (!trans) {
call = ERR_PTR(-ENOTCONN); call = ERR_PTR(-ENOTCONN);
goto out; goto out_notrans;
} }
atomic_inc(&trans->usage); atomic_inc(&trans->usage);
} }
@@ -315,6 +315,7 @@ struct rxrpc_call *rxrpc_kernel_begin_call(struct socket *sock,
rxrpc_put_bundle(trans, bundle); rxrpc_put_bundle(trans, bundle);
out: out:
rxrpc_put_transport(trans); rxrpc_put_transport(trans);
out_notrans:
release_sock(&rx->sk); release_sock(&rx->sk);
_leave(" = %p", call); _leave(" = %p", call);
return call; return call;