lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[MIPS] Simplify dump_stack()

Browse Source 
Make dump_stack() code not depend on CONFIG_KALLSYMS.

It also make prepare_frametrace() always inlined to get
less false entries reported by show_raw_backtrace().

Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Franck Bui-Huu
2006-08-03 09:29:19 +02:00
committed by Ralf Baechle
parent 6057a79876
commit 1666a6fc73
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
arch/mips/kernel/traps.c
View File

@@ -158,7 +158,7 @@ static void show_stacktrace(struct task_struct *task, struct pt_regs *regs)
show_backtrace(task, regs); show_backtrace(task, regs);
} }
static noinline void prepare_frametrace(struct pt_regs *regs) static __always_inline void prepare_frametrace(struct pt_regs *regs)
{ {
__asm__ __volatile__( __asm__ __volatile__(
"1: la $2, 1b\n\t" "1: la $2, 1b\n\t"
@@ -200,17 +200,15 @@ void show_stack(struct task_struct *task, unsigned long *sp)
*/ */
void dump_stack(void) void dump_stack(void)
{ {
unsigned long stack; struct pt_regs regs;
#ifdef CONFIG_KALLSYMS /*
if (!raw_show_trace) { * Remove any garbage that may be in regs (specially func
struct pt_regs regs; * addresses) to avoid show_raw_backtrace() to report them
prepare_frametrace(&regs); */
show_backtrace(current, &regs); memset(&regs, 0, sizeof(regs));
return; prepare_frametrace(&regs);
} show_backtrace(current, &regs);
#endif
show_raw_backtrace(&stack);
} }
EXPORT_SYMBOL(dump_stack); EXPORT_SYMBOL(dump_stack);