NFSv4: Add v4 exception handling for the ACL functions.
This is needed in order to handle any NFS4ERR_DELAY errors that might be returned by the server. It also ensures that we map the NFSv4 errors before they are returned to userland. Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> (cherry picked from 71c12b3f0abc7501f6ed231a6d17bc9c05a238dc commit)
This commit is contained in:
@@ -2668,7 +2668,7 @@ out:
|
|||||||
nfs4_set_cached_acl(inode, acl);
|
nfs4_set_cached_acl(inode, acl);
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline ssize_t nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t buflen)
|
static ssize_t __nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t buflen)
|
||||||
{
|
{
|
||||||
struct page *pages[NFS4ACL_MAXPAGES];
|
struct page *pages[NFS4ACL_MAXPAGES];
|
||||||
struct nfs_getaclargs args = {
|
struct nfs_getaclargs args = {
|
||||||
@@ -2721,6 +2721,19 @@ out_free:
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static ssize_t nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t buflen)
|
||||||
|
{
|
||||||
|
struct nfs4_exception exception = { };
|
||||||
|
ssize_t ret;
|
||||||
|
do {
|
||||||
|
ret = __nfs4_get_acl_uncached(inode, buf, buflen);
|
||||||
|
if (ret >= 0)
|
||||||
|
break;
|
||||||
|
ret = nfs4_handle_exception(NFS_SERVER(inode), ret, &exception);
|
||||||
|
} while (exception.retry);
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen)
|
static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen)
|
||||||
{
|
{
|
||||||
struct nfs_server *server = NFS_SERVER(inode);
|
struct nfs_server *server = NFS_SERVER(inode);
|
||||||
@@ -2737,7 +2750,7 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen)
|
|||||||
return nfs4_get_acl_uncached(inode, buf, buflen);
|
return nfs4_get_acl_uncached(inode, buf, buflen);
|
||||||
}
|
}
|
||||||
|
|
||||||
static int nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflen)
|
static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflen)
|
||||||
{
|
{
|
||||||
struct nfs_server *server = NFS_SERVER(inode);
|
struct nfs_server *server = NFS_SERVER(inode);
|
||||||
struct page *pages[NFS4ACL_MAXPAGES];
|
struct page *pages[NFS4ACL_MAXPAGES];
|
||||||
@@ -2763,6 +2776,18 @@ static int nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflen
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static int nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t buflen)
|
||||||
|
{
|
||||||
|
struct nfs4_exception exception = { };
|
||||||
|
int err;
|
||||||
|
do {
|
||||||
|
err = nfs4_handle_exception(NFS_SERVER(inode),
|
||||||
|
__nfs4_proc_set_acl(inode, buf, buflen),
|
||||||
|
&exception);
|
||||||
|
} while (exception.retry);
|
||||||
|
return err;
|
||||||
|
}
|
||||||
|
|
||||||
static int
|
static int
|
||||||
nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server)
|
nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server)
|
||||||
{
|
{
|
||||||
|
Reference in New Issue
Block a user