lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

MSI: Rename pci_msi_supported() to pci_msi_check_device()

Browse Source 
As pointed out by Eric, the name pci_msi_supported() suggests it should
return a boolean value, however it doesn't. So update the name to be
a bit less confusing and update the doco too.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Michael Ellerman
2007-04-05 17:19:07 +10:00
committed by Greg Kroah-Hartman
parent 128bc5fced
commit 17bbc12acd
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pci/msi.c
View File

@@ -457,15 +457,15 @@ static int msix_capability_init(struct pci_dev *dev,
} }
/** /**
* pci_msi_supported - check whether MSI may be enabled on device * pci_msi_check_device - check whether MSI may be enabled on a device
* @dev: pointer to the pci_dev data structure of MSI device function * @dev: pointer to the pci_dev data structure of MSI device function
* @type: are we checking for MSI or MSI-X ? * @type: are we checking for MSI or MSI-X ?
* *
* Look at global flags, the device itself, and its parent busses * Look at global flags, the device itself, and its parent busses
* to return 0 if MSI are supported for the device. * to determine if MSI/-X are supported for the device. If MSI/-X is
* supported return 0, else return an error code.
**/ **/
static static int pci_msi_check_device(struct pci_dev * dev, int type)
int pci_msi_supported(struct pci_dev * dev, int type)
{ {
struct pci_bus *bus; struct pci_bus *bus;
@@ -503,7 +503,7 @@ int pci_enable_msi(struct pci_dev* dev)
{ {
int status; int status;
if (pci_msi_supported(dev, PCI_CAP_ID_MSI)) if (pci_msi_check_device(dev, PCI_CAP_ID_MSI))
return -EINVAL; return -EINVAL;
WARN_ON(!!dev->msi_enabled); WARN_ON(!!dev->msi_enabled);
@@ -601,7 +601,7 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
int i, j; int i, j;
u16 control; u16 control;
if (!entries || pci_msi_supported(dev, PCI_CAP_ID_MSIX)) if (!entries || pci_msi_check_device(dev, PCI_CAP_ID_MSIX))
return -EINVAL; return -EINVAL;
pos = pci_find_capability(dev, PCI_CAP_ID_MSIX); pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);