lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SUNRPC]: Remove unnecessary check in net/sunrpc/svcsock.c

Browse Source 
coverity spotted this one as possible dereference in the dprintk(),
but since there is only one caller of svc_create_socket(), which always
passes a valid sin, we dont need this check.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Sesterhenn
2006-09-28 14:37:07 -07:00
committed by David S. Miller
parent 96d2ca4ec0
commit 1811474620
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
net/sunrpc/svcsock.c
View File

@@ -1393,14 +1393,12 @@ svc_create_socket(struct svc_serv *serv, int protocol, struct sockaddr_in *sin)
if ((error = sock_create_kern(PF_INET, type, protocol, &sock)) < 0) if ((error = sock_create_kern(PF_INET, type, protocol, &sock)) < 0)
return error; return error;
if (sin != NULL) { if (type == SOCK_STREAM)
if (type == SOCK_STREAM) sock->sk->sk_reuse = 1; /* allow address reuse */
sock->sk->sk_reuse = 1; /* allow address reuse */ error = kernel_bind(sock, (struct sockaddr *) sin,
error = kernel_bind(sock, (struct sockaddr *) sin, sizeof(*sin));
sizeof(*sin)); if (error < 0)
if (error < 0) goto bummer;
goto bummer;
}
if (protocol == IPPROTO_TCP) { if (protocol == IPPROTO_TCP) {
if ((error = kernel_listen(sock, 64)) < 0) if ((error = kernel_listen(sock, 64)) < 0)