lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

kobject: should use kobject_put() in kset-example

Browse Source 
We should call kobject_put() instead of kfree() if kobject_init_and_add()
returns an error, shouldn't we? Don't set up a bad example ;)

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Li Zefan
2008-06-13 11:09:16 +08:00
committed by Greg Kroah-Hartman
parent a231934bdf
commit 185000fc55
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
samples/kobject/kset-example.c
View File

@@ -211,7 +211,7 @@ static struct foo_obj *create_foo_obj(const char *name)
*/ */
retval = kobject_init_and_add(&foo->kobj, &foo_ktype, NULL, "%s", name); retval = kobject_init_and_add(&foo->kobj, &foo_ktype, NULL, "%s", name);
if (retval) { if (retval) {
kfree(foo); kobject_put(&foo->kobj);
return NULL; return NULL;
} }