lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[XFS] remove permission check from xfs_change_file_space

Browse Source 
Both callers of xfs_change_file_space alreaedy do the file->f_mode &
FMODE_WRITE check to ensure we have a file descriptor that has been opened
for write mode, so there is no need to re-check that with xfs_iaccess.
Especially as the later might wrongly deny it for corner cases like file
descriptor passing through unix domain sockets.

SGI-PV: 971186
SGI-Modid: xfs-linux-melb:xfs-kern:30365a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
This commit is contained in:
Christoph Hellwig
2008-02-05 12:12:58 +11:00
committed by Lachlan McIlroy
parent 9742bb93da
commit 199037c598
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fs/xfs/xfs_vnodeops.c
View File

@@ -4317,21 +4317,9 @@ xfs_change_file_space(
xfs_itrace_entry(ip); xfs_itrace_entry(ip);
/*
* must be a regular file and have write permission
*/
if (!S_ISREG(ip->i_d.di_mode)) if (!S_ISREG(ip->i_d.di_mode))
return XFS_ERROR(EINVAL); return XFS_ERROR(EINVAL);
xfs_ilock(ip, XFS_ILOCK_SHARED);
if ((error = xfs_iaccess(ip, S_IWUSR, credp))) {
xfs_iunlock(ip, XFS_ILOCK_SHARED);
return error;
}
xfs_iunlock(ip, XFS_ILOCK_SHARED);
switch (bf->l_whence) { switch (bf->l_whence) {
case 0: /*SEEK_SET*/ case 0: /*SEEK_SET*/
break; break;