lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rationalise return value for ->hot_add_disk method.

Browse Source 
For all array types but linear, ->hot_add_disk returns 1 on
success, 0 on failure.
For linear, it returns 0 on success and -errno on failure.

This doesn't cause a functional problem because the ->hot_add_disk
function of linear is used quite differently to the others.
However it is confusing.

So convert all to return 0 for success or -errno on failure
and fix call sites to match.

Signed-off-by: Neil Brown <neilb@suse.de>
This commit is contained in:
Neil Brown
2008-06-28 08:31:33 +10:00
parent 6c2fce2ef6
commit 199050ea1f
5 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/md/multipath.c
View File

@ -281,7 +281,7 @@ static int multipath_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
{
multipath_conf_t *conf = mddev->private;
struct request_queue *q;
int found = 0;
int err = -EEXIST;
int path;
struct multipath_info *p;
int first = 0;
@ -312,11 +312,13 @@ static int multipath_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
rdev->raid_disk = path;
set_bit(In_sync, &rdev->flags);
rcu_assign_pointer(p->rdev, rdev);
found = 1;
err = 0;
break;
}
print_multipath_conf(conf);
return found;
return err;
}
static int multipath_remove_disk(mddev_t *mddev, int number)