lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

infiniband: use for_each_set_bit()

Browse Source 
Replace open-coded loop with for_each_set_bit().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Roland Dreier <rolandd@cisco.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Akinobu Mita
2010-03-05 13:41:38 -08:00
committed by Linus Torvalds
parent 984b3f5746
commit 19b629f581
1 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/infiniband/core/mad.c
View File

@@ -1193,10 +1193,7 @@ static int method_in_use(struct ib_mad_mgmt_method_table **method,
{ {
int i; int i;
for (i = find_first_bit(mad_reg_req->method_mask, IB_MGMT_MAX_METHODS); for_each_set_bit(i, mad_reg_req->method_mask, IB_MGMT_MAX_METHODS) {
i < IB_MGMT_MAX_METHODS;
i = find_next_bit(mad_reg_req->method_mask, IB_MGMT_MAX_METHODS,
1+i)) {
if ((*method)->agent[i]) { if ((*method)->agent[i]) {
printk(KERN_ERR PFX "Method %d already in use\n", i); printk(KERN_ERR PFX "Method %d already in use\n", i);
return -EINVAL; return -EINVAL;
@@ -1330,13 +1327,9 @@ static int add_nonoui_reg_req(struct ib_mad_reg_req *mad_reg_req,
goto error3; goto error3;
/* Finally, add in methods being registered */ /* Finally, add in methods being registered */
for (i = find_first_bit(mad_reg_req->method_mask, for_each_set_bit(i, mad_reg_req->method_mask, IB_MGMT_MAX_METHODS)
IB_MGMT_MAX_METHODS);
i < IB_MGMT_MAX_METHODS;
i = find_next_bit(mad_reg_req->method_mask, IB_MGMT_MAX_METHODS,
1+i)) {
(*method)->agent[i] = agent_priv; (*method)->agent[i] = agent_priv;
}
return 0; return 0;
error3: error3:
@@ -1429,13 +1422,9 @@ check_in_use:
goto error4; goto error4;
/* Finally, add in methods being registered */ /* Finally, add in methods being registered */
for (i = find_first_bit(mad_reg_req->method_mask, for_each_set_bit(i, mad_reg_req->method_mask, IB_MGMT_MAX_METHODS)
IB_MGMT_MAX_METHODS);
i < IB_MGMT_MAX_METHODS;
i = find_next_bit(mad_reg_req->method_mask, IB_MGMT_MAX_METHODS,
1+i)) {
(*method)->agent[i] = agent_priv; (*method)->agent[i] = agent_priv;
}
return 0; return 0;
error4: error4: