lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[CPUFREQ] remove redundant sprintf from request_module call.

Browse Source 
Since format string handling is part of request_module, there is no
need to construct the module name. As such, drop the redundant sprintf
and heap usage.

Signed-off-by: Kees Cook <kees.cook@canonical.com>
Signed-off-by: Dave Jones <davej@redhat.com>
This commit is contained in:
Kees Cook
2011-05-04 08:38:56 -07:00
committed by Dave Jones
parent 469057d587
commit 1a8e1463a4
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/cpufreq/cpufreq.c
View File

@@ -321,21 +321,14 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
t = __find_governor(str_governor); t = __find_governor(str_governor);
if (t == NULL) { if (t == NULL) {
char *name = kasprintf(GFP_KERNEL, "cpufreq_%s", int ret;
str_governor);
if (name) { mutex_unlock(&cpufreq_governor_mutex);
int ret; ret = request_module("cpufreq_%s", str_governor);
mutex_lock(&cpufreq_governor_mutex);
mutex_unlock(&cpufreq_governor_mutex); if (ret == 0)
ret = request_module("%s", name); t = __find_governor(str_governor);
mutex_lock(&cpufreq_governor_mutex);
if (ret == 0)
t = __find_governor(str_governor);
}
kfree(name);
} }
if (t != NULL) { if (t != NULL) {