net: trans_start cleanups
Now that core network takes care of trans_start updates, dont do it in drivers themselves, if possible. Drivers can avoid one cache miss (on dev->trans_start) in their start_xmit() handler. Exceptions are NETIF_F_LLTX drivers Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
2b0b05ddc0
commit
1ae5dc342a
@@ -992,7 +992,7 @@ static void corkscrew_timeout(struct net_device *dev)
|
||||
if (!(inw(ioaddr + EL3_STATUS) & CmdInProgress))
|
||||
break;
|
||||
outw(TxEnable, ioaddr + EL3_CMD);
|
||||
dev->trans_start = jiffies;
|
||||
dev->trans_start = jiffies; /* prevent tx timeout */
|
||||
dev->stats.tx_errors++;
|
||||
dev->stats.tx_dropped++;
|
||||
netif_wake_queue(dev);
|
||||
@@ -1055,7 +1055,6 @@ static netdev_tx_t corkscrew_start_xmit(struct sk_buff *skb,
|
||||
prev_entry->status &= ~0x80000000;
|
||||
netif_wake_queue(dev);
|
||||
}
|
||||
dev->trans_start = jiffies;
|
||||
return NETDEV_TX_OK;
|
||||
}
|
||||
/* Put out the doubleword header... */
|
||||
@@ -1091,7 +1090,6 @@ static netdev_tx_t corkscrew_start_xmit(struct sk_buff *skb,
|
||||
outw(SetTxThreshold + (1536 >> 2), ioaddr + EL3_CMD);
|
||||
#endif /* bus master */
|
||||
|
||||
dev->trans_start = jiffies;
|
||||
|
||||
/* Clear the Tx status stack. */
|
||||
{
|
||||
|
Reference in New Issue
Block a user