lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] af9035: remove one config parameter

Browse Source 
We can use tuner ID instead of HW not supported flag.
Lesser code is better code.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Antti Palosaari
2012-05-07 14:59:55 -03:00
committed by Mauro Carvalho Chehab
parent 2a79eefa82
commit 1cbabf9c75
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/dvb/dvb-usb/af9035.c
View File

@@ -615,7 +615,6 @@ static int af9035_read_mac_address(struct dvb_usb_device *d, u8 mac[6])
state->af9033_config[i].spec_inv = 1; state->af9033_config[i].spec_inv = 1;
break; break;
default: default:
state->hw_not_supported = true;
warn("tuner ID=%02x not supported, please report!", warn("tuner ID=%02x not supported, please report!",
tmp); tmp);
}; };
@@ -809,7 +808,8 @@ static int af9035_frontend_attach(struct dvb_usb_adapter *adap)
struct state *state = adap->dev->priv; struct state *state = adap->dev->priv;
int ret; int ret;
if (state->hw_not_supported) { if (!state->af9033_config[adap->id].tuner) {
/* unsupported tuner */
ret = -ENODEV; ret = -ENODEV;
goto err; goto err;
} }

1
drivers/media/dvb/dvb-usb/af9035.h
View File

@@ -54,7 +54,6 @@ struct usb_req {
struct state { struct state {
bool dual_mode; bool dual_mode;
bool hw_not_supported;
struct af9033_config af9033_config[2]; struct af9033_config af9033_config[2];
}; };