lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] fuse: fix error case in fuse_readpages

Browse Source 
Don't let fuse_readpages leave the @pages list not empty when exiting
on error.

[akpm@osdl.org: kernel-doc fixes]
Signed-off-by: Alexander Zarochentsev <zam@namesys.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alexander Zarochentsev
2006-08-13 23:24:27 -07:00
committed by Greg Kroah-Hartman
parent 9b41ea7289
commit 1d7ea7324a
3 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/fuse/file.c
View File

@@ -395,14 +395,16 @@ static int fuse_readpages(struct file *file, struct address_space *mapping,
struct fuse_readpages_data data;
int err;
err = -EIO;
if (is_bad_inode(inode))
return -EIO;
goto clean_pages_up;
data.file = file;
data.inode = inode;
data.req = fuse_get_req(fc);
err = PTR_ERR(data.req);
if (IS_ERR(data.req))
return PTR_ERR(data.req);
goto clean_pages_up;
err = read_cache_pages(mapping, pages, fuse_readpages_fill, &data);
if (!err) {
@@ -412,6 +414,10 @@ static int fuse_readpages(struct file *file, struct address_space *mapping,
fuse_put_request(fc, data.req);
}
return err;
clean_pages_up:
put_pages_list(pages);
return err;
}
static size_t fuse_send_write(struct fuse_req *req, struct file *file,