lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

device create: framebuffer: convert device_create to device_create_drvdata

Browse Source 
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Cc: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Greg Kroah-Hartman
2008-05-21 12:52:33 -07:00
parent e282959ef3
commit 1e2744011f
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/video/console/fbcon.c
View File

@@ -3586,7 +3586,8 @@ static int __init fb_console_init(void)
acquire_console_sem(); acquire_console_sem();
fb_register_client(&fbcon_event_notifier); fb_register_client(&fbcon_event_notifier);
fbcon_device = device_create(fb_class, NULL, MKDEV(0, 0), "fbcon"); fbcon_device = device_create_drvdata(fb_class, NULL, MKDEV(0, 0),
NULL, "fbcon");
if (IS_ERR(fbcon_device)) { if (IS_ERR(fbcon_device)) {
printk(KERN_WARNING "Unable to create device " printk(KERN_WARNING "Unable to create device "

5
drivers/video/fbmem.c
View File

@@ -1439,8 +1439,9 @@ register_framebuffer(struct fb_info *fb_info)
break; break;
fb_info->node = i; fb_info->node = i;
fb_info->dev = device_create(fb_class, fb_info->device, fb_info->dev = device_create_drvdata(fb_class, fb_info->device,
MKDEV(FB_MAJOR, i), "fb%d", i); MKDEV(FB_MAJOR, i), NULL,
"fb%d", i);
if (IS_ERR(fb_info->dev)) { if (IS_ERR(fb_info->dev)) {
/* Not fatal */ /* Not fatal */
printk(KERN_WARNING "Unable to create device for framebuffer %d; errno = %ld\n", i, PTR_ERR(fb_info->dev)); printk(KERN_WARNING "Unable to create device for framebuffer %d; errno = %ld\n", i, PTR_ERR(fb_info->dev));