lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

leds: leds-ss4200: fix led_classdev_unregister twice in error handling

Browse Source 
In current implementation, if device_create_file failed in register_nasgpio_led,
led_classdev_unregister will be executed twice.
( in register_nasgpio_led it calls led_classdev_unregister before return and in nas_gpio_init out_err )

This patch fixes it by only unregistering those that were successfully registered in out_err.
( not including last failed register_nasgpio_led call )

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Dave Hansen <dave@sr71.net>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
This commit is contained in:
Axel Lin
2010-05-17 13:42:43 +08:00
committed by Richard Purdie
parent 7e1ce34f25
commit 1e653accf7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/leds/leds-ss4200.c
View File

@@ -534,7 +534,7 @@ static int __init nas_gpio_init(void)
set_power_light_amber_noblink(); set_power_light_amber_noblink();
return 0; return 0;
out_err: out_err:
for (; i >= 0; i--) for (i--; i >= 0; i--)
unregister_nasgpio_led(i); unregister_nasgpio_led(i);
pci_unregister_driver(&nas_gpio_pci_driver); pci_unregister_driver(&nas_gpio_pci_driver);
return ret; return ret;