lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB: dvb-usb: gp8psk, fix potential null derefernce

Browse Source 
Stanse found that in gp8psk_load_bcm4500fw there is missing a check for
return value of kmalloc. Add one and bail out appropriatelly.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Jiri Slaby
2010-04-27 18:11:20 -03:00
committed by Mauro Carvalho Chehab
parent 0de8e3533e
commit 205161ed03
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/dvb/dvb-usb/gp8psk.c
View File

@@ -105,6 +105,10 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d)
ptr = fw->data; ptr = fw->data;
buf = kmalloc(64, GFP_KERNEL | GFP_DMA); buf = kmalloc(64, GFP_KERNEL | GFP_DMA);
if (!buf) {
ret = -ENOMEM;
goto out_rel_fw;
}
while (ptr[0] != 0xff) { while (ptr[0] != 0xff) {
u16 buflen = ptr[0] + 4; u16 buflen = ptr[0] + 4;