lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

usbcore: cdev lock_kernel() pushdown

Browse Source 
usb_open() is protected by a down_read(&minor_rwsem), but I'm not sure I
trust it to protect everything including subsidiary open() functions.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Jonathan Corbet
2008-05-15 16:24:25 -06:00
parent 1bcaa0bd6f
commit 20613f24bc
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/core/file.c
View File

@@ -18,6 +18,7 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/rwsem.h> #include <linux/rwsem.h>
#include <linux/smp_lock.h>
#include <linux/usb.h> #include <linux/usb.h>
#include "usb.h" #include "usb.h"
@@ -33,6 +34,7 @@ static int usb_open(struct inode * inode, struct file * file)
int err = -ENODEV; int err = -ENODEV;
const struct file_operations *old_fops, *new_fops = NULL; const struct file_operations *old_fops, *new_fops = NULL;
lock_kernel();
down_read(&minor_rwsem); down_read(&minor_rwsem);
c = usb_minors[minor]; c = usb_minors[minor];
@@ -51,6 +53,7 @@ static int usb_open(struct inode * inode, struct file * file)
fops_put(old_fops); fops_put(old_fops);
done: done:
up_read(&minor_rwsem); up_read(&minor_rwsem);
unlock_kernel();
return err; return err;
} }