lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove useless mnt_want_write call in xfs_write

Browse Source 
When mnt_want_write was introduced a call to it was added around
xfs_ichgtime, but there is no need for this because a file can't be open
read/write on a r/o mount, and a mount can't degrade r/o while we still
have files open for writing.  As the mnt_want_write changes were never
merged into the CVS tree this patch is for mainline only.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
This commit is contained in:
Christoph Hellwig
2008-12-03 12:20:22 +01:00
committed by Niv Sardi
parent ddcd856d81
commit 2234d54d3d
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/xfs/linux-2.6/xfs_lrw.c
View File

@@ -51,7 +51,6 @@
#include "xfs_vnodeops.h" #include "xfs_vnodeops.h"
#include <linux/capability.h> #include <linux/capability.h>
#include <linux/mount.h>
#include <linux/writeback.h> #include <linux/writeback.h>
@@ -668,15 +667,8 @@ start:
if (new_size > xip->i_size) if (new_size > xip->i_size)
xip->i_new_size = new_size; xip->i_new_size = new_size;
/* if (likely(!(ioflags & IO_INVIS)))
* We're not supposed to change timestamps in readonly-mounted
* filesystems. Throw it away if anyone asks us.
*/
if (likely(!(ioflags & IO_INVIS) &&
!mnt_want_write(file->f_path.mnt))) {
xfs_ichgtime(xip, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); xfs_ichgtime(xip, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
mnt_drop_write(file->f_path.mnt);
}
/* /*
* If the offset is beyond the size of the file, we have a couple * If the offset is beyond the size of the file, we have a couple