lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: rt2860: test off by one in RtmpAsicSendCommandToMcu()

Browse Source 
`i' reaches 101 after the loop, so if it was 100 then it succeeded in
the last iteration. This is probably unlikely to cause problems.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Roel Kluin
2009-12-26 20:00:47 +01:00
committed by Greg Kroah-Hartman
parent 716323c093
commit 23a51a8061
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/rt2860/common/rtmp_mcu.c
View File

@@ -221,7 +221,7 @@ int RtmpAsicSendCommandToMcu(struct rt_rtmp_adapter *pAd,
("AsicSendCommanToMcu::Mail box is busy\n")); ("AsicSendCommanToMcu::Mail box is busy\n"));
} while (i++ < 100); } while (i++ < 100);
if (i >= 100) { if (i > 100) {
DBGPRINT_ERR(("H2M_MAILBOX still hold by MCU. command fail\n")); DBGPRINT_ERR(("H2M_MAILBOX still hold by MCU. command fail\n"));
return FALSE; return FALSE;
} }