lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mwl8k: ->add_interface() is not called for monitor interfaces

Browse Source 
There is no need to check for NL80211_IFTYPE_MONITOR in
->add_interface(), as this function is never called for monitor
interfaces.  Also, there is no need to advertise this bit in our
wiphy's ->interface_modes.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Lennert Buytenhek
2009-07-16 14:15:44 +02:00
committed by John W. Linville
parent e81cd2d664
commit 240e86efd6
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/mwl8k.c
View File

@@ -2883,8 +2883,7 @@ static int mwl8k_add_interface(struct ieee80211_hw *hw,
/* /*
* We only support managed interfaces for now. * We only support managed interfaces for now.
*/ */
if (conf->type != NL80211_IFTYPE_STATION && if (conf->type != NL80211_IFTYPE_STATION)
conf->type != NL80211_IFTYPE_MONITOR)
return -EINVAL; return -EINVAL;
/* Clean out driver private area */ /* Clean out driver private area */
@@ -3440,8 +3439,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
hw->queues = MWL8K_TX_QUEUES; hw->queues = MWL8K_TX_QUEUES;
hw->wiphy->interface_modes = hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_MONITOR);
/* Set rssi and noise values to dBm */ /* Set rssi and noise values to dBm */
hw->flags |= IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_NOISE_DBM; hw->flags |= IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_NOISE_DBM;