lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] UHCI: Don't store device pointer in QH or TD

Browse Source 
This patch simplifies the uhci-hcd driver by removing the device pointer
currently stored in the QH and TD structures.  Those pointers weren't
being used for anything other than to increment the device's reference
count, which is unnecessary since the device is used only when an URB
completes, and outstanding URBs take their own reference to the device.
As a useful side effect, this change means that uhci-hcd no longer needs
to have the root-hub device available in the start routine.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alan Stern
2005-04-25 11:14:31 -04:00
committed by Greg Kroah-Hartman
parent 7d35b92985
commit 2532178a68
3 changed files with 12 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/host/uhci-hcd.h
View File

@ -114,7 +114,6 @@ struct uhci_qh {
/* Software fields */
dma_addr_t dma_handle;
struct usb_device *dev;
struct urb_priv *urbp;
struct list_head list; /* P: uhci->frame_list_lock */
@ -206,7 +205,6 @@ struct uhci_td {
/* Software fields */
dma_addr_t dma_handle;
struct usb_device *dev;
struct urb *urb;
struct list_head list; /* P: urb->lock */