lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix debugfs_create_file's error checking method for arch/sh/mm/

Browse Source 
debugfs_create_file() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Zhaolei
2008-10-17 19:25:09 +08:00
committed by Paul Mundt
parent 9986b311ef
commit 25627c7fd7
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
arch/sh/mm/cache-debugfs.c
View File

@@ -130,12 +130,18 @@ static int __init cache_debugfs_init(void)
dcache_dentry = debugfs_create_file("dcache", S_IRUSR, sh_debugfs_root, dcache_dentry = debugfs_create_file("dcache", S_IRUSR, sh_debugfs_root,
(unsigned int *)CACHE_TYPE_DCACHE, (unsigned int *)CACHE_TYPE_DCACHE,
&cache_debugfs_fops); &cache_debugfs_fops);
if (!dcache_dentry)
return -ENOMEM;
if (IS_ERR(dcache_dentry)) if (IS_ERR(dcache_dentry))
return PTR_ERR(dcache_dentry); return PTR_ERR(dcache_dentry);
icache_dentry = debugfs_create_file("icache", S_IRUSR, sh_debugfs_root, icache_dentry = debugfs_create_file("icache", S_IRUSR, sh_debugfs_root,
(unsigned int *)CACHE_TYPE_ICACHE, (unsigned int *)CACHE_TYPE_ICACHE,
&cache_debugfs_fops); &cache_debugfs_fops);
if (!icache_dentry) {
debugfs_remove(dcache_dentry);
return -ENOMEM;
}
if (IS_ERR(icache_dentry)) { if (IS_ERR(icache_dentry)) {
debugfs_remove(dcache_dentry); debugfs_remove(dcache_dentry);
return PTR_ERR(icache_dentry); return PTR_ERR(icache_dentry);

2
arch/sh/mm/pmb.c
View File

@@ -394,6 +394,8 @@ static int __init pmb_debugfs_init(void)
dentry = debugfs_create_file("pmb", S_IFREG | S_IRUGO, dentry = debugfs_create_file("pmb", S_IFREG | S_IRUGO,
sh_debugfs_root, NULL, &pmb_debugfs_fops); sh_debugfs_root, NULL, &pmb_debugfs_fops);
if (!dentry)
return -ENOMEM;
if (IS_ERR(dentry)) if (IS_ERR(dentry))
return PTR_ERR(dentry); return PTR_ERR(dentry);