ethtool: Use full 32 bit speed range in ethtool's set_settings
This makes sure the ethtool's set_settings() callback of network drivers don't ignore the 16 most significant bits when ethtool calls their set_settings(). All drivers compiled with make allyesconfig on x86_64 have been updated. Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
8ae6daca85
commit
25db033881
@@ -3452,8 +3452,9 @@ static int sky2_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
|
||||
sky2->speed = -1;
|
||||
} else {
|
||||
u32 setting;
|
||||
u32 speed = ethtool_cmd_speed(ecmd);
|
||||
|
||||
switch (ecmd->speed) {
|
||||
switch (speed) {
|
||||
case SPEED_1000:
|
||||
if (ecmd->duplex == DUPLEX_FULL)
|
||||
setting = SUPPORTED_1000baseT_Full;
|
||||
@@ -3486,7 +3487,7 @@ static int sky2_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
|
||||
if ((setting & supported) == 0)
|
||||
return -EINVAL;
|
||||
|
||||
sky2->speed = ecmd->speed;
|
||||
sky2->speed = speed;
|
||||
sky2->duplex = ecmd->duplex;
|
||||
sky2->flags &= ~SKY2_FLAG_AUTO_SPEED;
|
||||
}
|
||||
|
Reference in New Issue
Block a user