lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

kconfig: avoid multiple calls to strlen

Browse Source 
Calls to strlen are costly, so avoid calling strln as much as we can.

Reported-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
This commit is contained in:
Yann E. MORIN
2013-07-13 15:09:43 +02:00
parent 9e554dd7b2
commit 26e933e3c3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/kconfig/symbol.c
View File

@@ -967,7 +967,7 @@ static int sym_rel_comp( const void *sym1, const void *sym2 )
{ {
struct sym_match *s1 = *(struct sym_match **)sym1; struct sym_match *s1 = *(struct sym_match **)sym1;
struct sym_match *s2 = *(struct sym_match **)sym2; struct sym_match *s2 = *(struct sym_match **)sym2;
int l1, l2; int exact1, exact2;
/* Exact match: /* Exact match:
* - if matched length on symbol s1 is the length of that symbol, * - if matched length on symbol s1 is the length of that symbol,
@@ -978,11 +978,11 @@ static int sym_rel_comp( const void *sym1, const void *sym2 )
* exactly; if this is the case, we can't decide which comes first, * exactly; if this is the case, we can't decide which comes first,
* and we fallback to sorting alphabetically. * and we fallback to sorting alphabetically.
*/ */
l1 = s1->eo - s1->so; exact1 = (s1->eo - s1->so) == strlen(s1->sym->name);
l2 = s2->eo - s2->so; exact2 = (s2->eo - s2->so) == strlen(s2->sym->name);
if (l1 == strlen(s1->sym->name) && l2 != strlen(s2->sym->name)) if (exact1 && !exact2)
return -1; return -1;
if (l1 != strlen(s1->sym->name) && l2 == strlen(s2->sym->name)) if (!exact1 && exact2)
return 1; return 1;
/* As a fallback, sort symbols alphabetically */ /* As a fallback, sort symbols alphabetically */